Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding mu and r to virtual packet logging #1696

Merged
merged 4 commits into from
Jul 9, 2021
Merged

Adding mu and r to virtual packet logging #1696

merged 4 commits into from
Jul 9, 2021

Conversation

isaacgsmith
Copy link
Member

This allows virtual packet logging to track the initial propagation direction and radius of the virtual packets.

Description

If virtual packet logging is turned on, the list of initial propagation directions and radii of the virtual packets are respectively accessible via MontecarloRunner.virt_packet_initial_mus and MontecarloRunner.virt_packet_initial_rs.

Motivation and context

This will be helpful with visualizing the virtual packets, as well as with analyzing them.

How has this been tested?

  • Testing pipeline.
  • Other.

Examples

image

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@tardis-bot
Copy link
Contributor

tardis-bot commented Jul 7, 2021 •
edited by andrewfullard
Loading

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

@isaacgsmith isaacgsmith changed the title Vpacket log Adding mu and r to virtual packet logging Jul 7, 2021
@isaacgsmith isaacgsmith requested review from Rodot- and removed request for wkerzendorf July 7, 2021 15:47
@codecov
Copy link

codecov bot commented Jul 7, 2021 •
edited
Loading

Codecov Report

Merging #1696 (4c44695) into master (cc0410e) will decrease coverage by 0.19%.
The diff coverage is n/a.

❗ Current head 4c44695 differs from pull request most recent head e44c392. Consider uploading reports for the commit e44c392 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1696      +/-   ##
==========================================
- Coverage   61.29%   61.09%   -0.20%     
==========================================
  Files          63       63              
  Lines        5792     5814      +22     
==========================================
+ Hits         3550     3552       +2     
- Misses       2242     2262      +20
Impacted Files Coverage Δ
...dis/montecarlo/montecarlo_numba/numba_interface.py 46.15% <0.00%> (-3.48%) ⬇️
tardis/tardis/montecarlo/montecarlo_numba/base.py 25.77% <0.00%> (-2.97%) ⬇️
tardis/tardis/montecarlo/base.py 88.77% <0.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc0410e...e44c392. Read the comment docs.

andrewfullard
andrewfullard approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@andrewfullard andrewfullard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

Rodot-
Rodot- approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@Rodot- Rodot- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@andrewfullard andrewfullard merged commit 9ac481d into tardis-sn:master Jul 9, 2021
@isaacgsmith isaacgsmith deleted the vpacket-logging-addition branch July 9, 2021 22:37
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
@isaacgsmith
Adding mu and r to virtual packet logging (tardis-sn#1696)
f637d36 
* added r and mu to vpacket logging

* fixing problem with merge conflict

* fixing test failure

* making documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewfullard andrewfullard andrewfullard approved these changes

@Rodot- Rodot- Rodot- approved these changes

Assignees
No one assigned
Labels
virtual packets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@isaacgsmith @tardis-bot @Rodot- @andrewfullard